On 08/10/17 11:24, Vinod Koul wrote:
> On Mon, Oct 02, 2017 at 10:44:39AM +0100, Ed Blake wrote:
>> +static int img_mdc_resume_early(struct device *dev)
>> +{
>> + struct mdc_dma *mdma = dev_get_drvdata(dev);
>> + int ret = 0;
>> +
>> + ret = clk_prepare_enable(mdma->clk);
> this can be return clk_prepare_enable()
>
OK, I'll fix this in v2.
>> +
>> + return ret;
>> +}
>> +#endif /* CONFIG_PM_SLEEP */
>> +
>> +static const struct dev_pm_ops img_mdc_pm_ops = {
>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(img_mdc_suspend_late,
>> + img_mdc_resume_early)
> any reason for late ops?
>
I explained this in the commit message:
>> DMA drivers should use suspend_late / resume_early to ensure that all
>> DMA client devices are suspended before the DMA device itself, and that
>> client devices are resumed after the DMA device. This avoids suspending
>> the DMA device while transactions are still active.
Ed.
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
