Re: [PATCH] dmaengine: acpi: Fix coding style and misspelled issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 06, 2017 at 11:02:54PM +0200, Daniel Zielas wrote:
> Types of issues which are fixed:
> - line over 80 characters
> - alignment should match open parenthesis
> - changed misspelled word 'avaiable' to 'available'

please send separate patches for each of these..

> 
> Signed-off-by: Daniel Zielas <zielas.daniel@xxxxxxxxx>
> ---
>  drivers/dma/acpi-dma.c | 36 ++++++++++++++++++++----------------
>  1 file changed, 20 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/dma/acpi-dma.c b/drivers/dma/acpi-dma.c
> index 4a748c3435d7..46d2a9848066 100644
> --- a/drivers/dma/acpi-dma.c
> +++ b/drivers/dma/acpi-dma.c
> @@ -41,7 +41,8 @@ static DEFINE_MUTEX(acpi_dma_lock);
>   * on error.
>   */
>  static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
> -		struct acpi_device *adev, struct acpi_dma *adma)
> +					 struct acpi_device *adev,
> +					 struct acpi_dma *adma)

this is no better than previous!

>  {
>  	const struct acpi_csrt_shared_info *si;
>  	struct list_head resource_list;
> @@ -153,9 +154,9 @@ static void acpi_dma_parse_csrt(struct acpi_device *adev, struct acpi_dma *adma)
>   * 0 on success or appropriate errno value on error.
>   */
>  int acpi_dma_controller_register(struct device *dev,
> -		struct dma_chan *(*acpi_dma_xlate)
> -		(struct acpi_dma_spec *, struct acpi_dma *),
> -		void *data)
> +				 struct dma_chan *(*acpi_dma_xlate)
> +				 (struct acpi_dma_spec *, struct acpi_dma *),
> +				 void *data)

same here

>  {
>  	struct acpi_device *adev;
>  	struct acpi_dma	*adma;
> @@ -224,7 +225,8 @@ static void devm_acpi_dma_release(struct device *dev, void *res)
>  }
>  
>  /**
> - * devm_acpi_dma_controller_register - resource managed acpi_dma_controller_register()
> + * devm_acpi_dma_controller_register - resource managed
> + * acpi_dma_controller_register()
>   * @dev:		device that is registering this DMA controller
>   * @acpi_dma_xlate:	translation function
>   * @data		pointer to controller specific data
> @@ -237,9 +239,9 @@ static void devm_acpi_dma_release(struct device *dev, void *res)
>   * 0 on success or appropriate errno value on error.
>   */
>  int devm_acpi_dma_controller_register(struct device *dev,
> -		struct dma_chan *(*acpi_dma_xlate)
> -		(struct acpi_dma_spec *, struct acpi_dma *),
> -		void *data)
> +				      struct dma_chan *(*acpi_dma_xlate)
> +				   (struct acpi_dma_spec *, struct acpi_dma *),
> +				      void *data)
>  {
>  	void *res;
>  	int ret;
> @@ -273,7 +275,8 @@ void devm_acpi_dma_controller_free(struct device *dev)
>  EXPORT_SYMBOL_GPL(devm_acpi_dma_controller_free);
>  
>  /**
> - * acpi_dma_update_dma_spec - prepare dma specifier to pass to translation function
> + * acpi_dma_update_dma_spec - prepare dma specifier to pass to translation
> + * function
>   * @adma:	struct acpi_dma of DMA controller
>   * @dma_spec:	dma specifier to update
>   *
> @@ -286,10 +289,10 @@ EXPORT_SYMBOL_GPL(devm_acpi_dma_controller_free);
>   * found.
>   *
>   * Return:
> - * 0, if no information is avaiable, -1 on mismatch, and 1 otherwise.
> + * 0, if no information is available, -1 on mismatch, and 1 otherwise.
>   */
>  static int acpi_dma_update_dma_spec(struct acpi_dma *adma,
> -		struct acpi_dma_spec *dma_spec)
> +				    struct acpi_dma_spec *dma_spec)
>  {
>  	/* Set link to the DMA controller device */
>  	dma_spec->dev = adma->dev;
> @@ -349,7 +352,7 @@ static int acpi_dma_parse_fixed_dma(struct acpi_resource *res, void *data)
>   * Pointer to appropriate dma channel on success or an error pointer.
>   */
>  struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,
> -		size_t index)
> +						      size_t index)
>  {
>  	struct acpi_dma_parser_data pdata;
>  	struct acpi_dma_spec *dma_spec = &pdata.dma_spec;
> @@ -376,7 +379,7 @@ struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,
>  
>  	INIT_LIST_HEAD(&resource_list);
>  	acpi_dev_get_resources(adev, &resource_list,
> -			acpi_dma_parse_fixed_dma, &pdata);
> +			       acpi_dma_parse_fixed_dma, &pdata);
>  	acpi_dev_free_resource_list(&resource_list);
>  
>  	if (dma_spec->slave_id < 0 || dma_spec->chan_id < 0)
> @@ -424,7 +427,7 @@ EXPORT_SYMBOL_GPL(acpi_dma_request_slave_chan_by_index);
>   * Pointer to appropriate dma channel on success or an error pointer.
>   */
>  struct dma_chan *acpi_dma_request_slave_chan_by_name(struct device *dev,
> -		const char *name)
> +						     const char *name)
>  {
>  	int index;
>  
> @@ -438,7 +441,8 @@ struct dma_chan *acpi_dma_request_slave_chan_by_name(struct device *dev,
>  			return ERR_PTR(-ENODEV);
>  	}
>  
> -	dev_dbg(dev, "Looking for DMA channel \"%s\" at index %d...\n", name, index);
> +	dev_dbg(dev, "Looking for DMA channel \"%s\" at index %d...\n", name,
> +		index);

this is not better than previous

>  	return acpi_dma_request_slave_chan_by_index(dev, index);
>  }
>  EXPORT_SYMBOL_GPL(acpi_dma_request_slave_chan_by_name);
> @@ -455,7 +459,7 @@ EXPORT_SYMBOL_GPL(acpi_dma_request_slave_chan_by_name);
>   * Pointer to the channel if found or %NULL otherwise.
>   */
>  struct dma_chan *acpi_dma_simple_xlate(struct acpi_dma_spec *dma_spec,
> -		struct acpi_dma *adma)
> +				       struct acpi_dma *adma)
>  {
>  	struct acpi_dma_filter_info *info = adma->data;
>  
> -- 
> 2.13.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux