Re: [PATCH] dmaengine: xilinx_dma: Move enum xdma_ip_type to driver file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5.9.2017 16:43, Lars-Peter Clausen wrote:
> The enum xdma_ip_type is only used inside the Xilinx DMA driver and not
> exported to any consumers (nor should it be). So move it from the global
> header to driver file itself.
> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 14 ++++++++++++++
>  include/linux/dma/xilinx_dma.h  | 14 --------------
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 8722bcba489d..5eef13380ca8 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -366,6 +366,20 @@ struct xilinx_dma_chan {
>  	u16 tdest;
>  };
>  
> +/**
> + * enum xdma_ip_type: DMA IP type.
> + *
> + * XDMA_TYPE_AXIDMA: Axi dma ip.
> + * XDMA_TYPE_CDMA: Axi cdma ip.
> + * XDMA_TYPE_VDMA: Axi vdma ip.
> + *
> + */
> +enum xdma_ip_type {
> +	XDMA_TYPE_AXIDMA = 0,
> +	XDMA_TYPE_CDMA,
> +	XDMA_TYPE_VDMA,
> +};
> +
>  struct xilinx_dma_config {
>  	enum xdma_ip_type dmatype;
>  	int (*clk_init)(struct platform_device *pdev, struct clk **axi_clk,
> diff --git a/include/linux/dma/xilinx_dma.h b/include/linux/dma/xilinx_dma.h
> index 3ae300052553..34b98f276ed0 100644
> --- a/include/linux/dma/xilinx_dma.h
> +++ b/include/linux/dma/xilinx_dma.h
> @@ -41,20 +41,6 @@ struct xilinx_vdma_config {
>  	int ext_fsync;
>  };
>  
> -/**
> - * enum xdma_ip_type: DMA IP type.
> - *
> - * XDMA_TYPE_AXIDMA: Axi dma ip.
> - * XDMA_TYPE_CDMA: Axi cdma ip.
> - * XDMA_TYPE_VDMA: Axi vdma ip.
> - *
> - */
> -enum xdma_ip_type {
> -	XDMA_TYPE_AXIDMA = 0,
> -	XDMA_TYPE_CDMA,
> -	XDMA_TYPE_VDMA,
> -};
> -
>  int xilinx_vdma_channel_set_config(struct dma_chan *dchan,
>  					struct xilinx_vdma_config *cfg);
>  
> 

Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux