On Thu, Sep 07, 2017 at 09:37:32PM +0200, Greg KH wrote: > On Fri, Aug 18, 2017 at 10:56:13AM +0530, Vinod Koul wrote: > > On Fri, Aug 18, 2017 at 10:33:54AM +0530, Anup Patel wrote: > > > On Thu, Aug 17, 2017 at 1:31 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > > > > On Tue, Aug 01, 2017 at 04:07:59PM +0530, Anup Patel wrote: > > > > why fail, debugfs should be an optional thingy, why would you want to fail here? > > > > > > Yes, we are handling the case when debugfs is not available > > > and skipping debugfs gracefully. > > > > > > If debugfs is available then failure of debugfs_create_dir() > > > should be reported. > > > > reported yes, bailing out on that err no.. > > Reported, no. You should _never_ care about the return value of a > debugfs call. Never check it, just move on ad keep on going. It > doesn't matter. Agreed that makes more sense. The driver was checking and bailing out, I advised against that :) -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
