On Sat, Aug 26, 2017 at 09:59:07AM +0200, Stefan Roese wrote: > This patch moves from a struct declaration for the DMA controller > registers to macros with offests to the base address. This is mainly > done to remove the sparse warnings, since the function parameter of > ioread32/iowrite32 is "void __iomem *" instead of a pointer to struct > members. With this patch applied, no sparse warning is seen anymore. > > Please note that the struct for the descriptors is still kept in place, > as the code largely accesses the struct members as internal variables > before the complete struct is copied into the descriptor FIFO of the > DMA controller. > > Additionally this patch also removes two warnings "variable xxx set but > not used" seen when compiling with "W=1". The registers need to be read > to flush the response FIFO, but nothing needs to be done with them. So > the code is correct here and the warning is a false one. > > Signed-off-by: Stefan Roese <sr@xxxxxxx> > Cc: Vinod Koul <vinod.koul@xxxxxxxxx> well this is more work for me to remove this line while applying, so a useful trick is to add cc after the --- line which git am happily ignores :) Applied now, thanks > --- > Please note that the following patch needs to be applied to quiet some > incorrect sparse warnings when compiling this driver for ARM on 64bit > platforms (GENMASK issue): > > "arm: fix sparse flags for build on 64bit machines" > https://patchwork.kernel.org/patch/9864431/ -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
