On Sun, Aug 27, 2017 at 08:09:49AM -0700, Dan Williams wrote:
> On Sun, Aug 27, 2017 at 4:28 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> > +
> > + if (dma_has_cap(DMA_MEMCPY, device->cap_mask) && !device->device_prep_dma_memcpy) {
> > + dev_err(device->dev, "Device support memcpy but no ops\n");
> > + return -EIO;
>
> How about fixing up the error message to the form: "Device claims the
> capability, but the %s operation is not defined."
Sounds good, updated now..
>
> Otherwise, looks good to me:
>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Thanks
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
