On Fri, Aug 18, 2017 at 10:55 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > On Fri, Aug 18, 2017 at 10:26:54AM +0530, Anup Patel wrote: >> On Thu, Aug 17, 2017 at 9:15 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: >> > On Tue, Aug 01, 2017 at 04:07:47PM +0530, Anup Patel wrote: >> >> This patch merges sba_request state and fence into common >> >> sba_request flags. Also, in-future we can extend sba_request >> >> flags as required. >> > >> > and it also changes the flag values to bits, which I have no idea why that >> > was done, care to explain that please... >> >> I thought its better to have separate bit each sba_request state so >> that when a sba_request is accidentally in two states then we can >> debug better. > > that is fine, but you need to comminucate the motivation behind such a > change!! Okay, I will add this info to commit description. > >> >> I will restore state values. > > either ways am okay, but if we are not using bits smartly then why to change Okay, I will keep new state values as-is and only update commit description. Regards, Anup -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
