Hi Vinod,
On 18.07.2017 18:42, Vinod Koul wrote:
On Fri, Jul 07, 2017 at 02:11:19PM +0200, Stefan Roese wrote:
This driver adds support for the Altera / Intel modular Scatter-Gather
Direct Memory Access (mSGDMA) intellectual property (IP) to the Linux
DMAengine subsystem. Currently it supports the following op modes:
- DMA_MEMCPY
- DMA_SG
- DMA_SLAVE
This implementation has been tested on an Altera Cyclone FPGA connected
via PCIe, both on an ARM and an x86 platform.
Applied, thanks
I am getting following warn and looking at code, I am not able to decide if
its harmless as a comment indicates reads maybe required.
The reads are required. I had hoped that the comment was explicit
enough.
drivers/dma/altera-msgdma.c: In function ‘msgdma_tasklet’:
drivers/dma/altera-msgdma.c:786:6: warning: variable ‘status’ set but not
used [-Wunused-but-set-variable]
u32 status;
^
drivers/dma/altera-msgdma.c:785:6: warning: variable ‘size’ set but not used
[-Wunused-but-set-variable]
u32 size;
^
I'm not seeing this warning (gcc 6.3.1 on ARM and gcc 5.4.0 on x86).
Which toolchain and platform are you using that produces this
warning?
Also there are bunch of sparse warns, please fix them up as well.
Will do.
Thanks,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
