[PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
enabled (seen on x86_64).

drivers/built-in.o: In function `sba_prep_dma_pq_req':
(.text+0x16132): undefined reference to `raid6_gflog'
drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
(.text+0x162f4): undefined reference to `raid6_gflog'

This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
ARM64 or COMPILE_TEST.

However, RAID6_PQ is not defined in any Kconfig file, although it is
used in several of them. :(

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Anup Patel <anup.patel@xxxxxxxxxxxx>
Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
Cc: dmaengine@xxxxxxxxxxxxxxx
---
 drivers/dma/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20170517.orig/drivers/dma/Kconfig
+++ linux-next-20170517/drivers/dma/Kconfig
@@ -101,7 +101,8 @@ config AXI_DMAC
 
 config BCM_SBA_RAID
 	tristate "Broadcom SBA RAID engine support"
-	depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
+	depends on ARM64 || COMPILE_TEST
+	depends on MAILBOX && RAID6_PQ
 	select DMA_ENGINE
 	select DMA_ENGINE_RAID
 	select ASYNC_TX_DISABLE_XOR_VAL_DMA


--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux