Hello Markus, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Sat, 22 Apr 2017 23:00:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". I have trouble parsing that sentences. This looks like the typical approach of native german speakers to directly transfer sentence constructions from German to English. Which, in most cases, doesn't work or is just plain confusing. With best wishes, Tobias > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/dma/s3c24xx-dma.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c > index f04c4702d98b..967229829683 100644 > --- a/drivers/dma/s3c24xx-dma.c > +++ b/drivers/dma/s3c24xx-dma.c > @@ -1216,10 +1216,10 @@ static int s3c24xx_dma_probe(struct platform_device *pdev) > if (IS_ERR(s3cdma->base)) > return PTR_ERR(s3cdma->base); > > - s3cdma->phy_chans = devm_kzalloc(&pdev->dev, > - sizeof(struct s3c24xx_dma_phy) * > - pdata->num_phy_channels, > - GFP_KERNEL); > + s3cdma->phy_chans = devm_kcalloc(&pdev->dev, > + pdata->num_phy_channels, > + sizeof(*s3cdma->phy_chans), > + GFP_KERNEL); > if (!s3cdma->phy_chans) > return -ENOMEM; > > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
