On Tue, Mar 14, 2017 at 10:12:57AM +0530, Shubhrajyoti Datta wrote: > On Tue, Mar 14, 2017 at 10:04 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > > On Thu, Mar 09, 2017 at 12:49:18PM +0530, Shubhrajyoti Datta wrote: > >> dma_init access registers it should be done after clk > >> enable. The patch does the same. > > > > and why is that? > > To read registers abp clock is to be enabled > so the order should be to > enable clock > and then read write registers. first why funny wrap? second, good but this needs to be part of change log and helps in reveiw. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html