On Tue, Mar 14, 2017 at 10:04 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > On Thu, Mar 09, 2017 at 12:49:17PM +0530, Shubhrajyoti Datta wrote: >> Add runtime support for the dma driver. > > runtime pm right? yes > >> >> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> >> --- >> drivers/dma/xilinx/zynqmp_dma.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c >> index 6d221e5..dbc102d 100644 >> --- a/drivers/dma/xilinx/zynqmp_dma.c >> +++ b/drivers/dma/xilinx/zynqmp_dma.c >> @@ -23,6 +23,7 @@ >> #include <linux/slab.h> >> #include <linux/clk.h> >> #include <linux/io-64-nonatomic-lo-hi.h> >> +#include <linux/pm_runtime.h> >> >> #include "../dmaengine.h" >> >> @@ -1027,6 +1028,9 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev, >> return err; >> } >> >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); > > This makes no sense, runtime pm means actively managing device power which > is not the case, so what exactly are you trying here Yes however some of the power domain driver stuff relies on truthfully reporting the runtime state so I was trying to set the state to active when using it. However you are right we are working on actively managing the device power patch also. will get back. > > -- > ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
