[...] >> >> Marek, this is great work! It's been on my TODO list forever, so I >> really appreciate your work here. >> >> I did only a brief review so far, particularly concentrating on the >> changes for device links and runtime PM. I like it! >> >> Perhaps we can get someone like Arnd/Vinod to comment in general idea >> from a DT and DMA slave channel point of view. I don't know that stuff >> good enough to give good opinion. > > > Arnd already said that it looks good: > http://www.spinics.net/lists/dmaengine/msg12186.html Great! Clearly, I haven't fully catched up since the holidays. :-) > >> A couple of things that crosses my mind so far: >> 1) I have planned to extend pm_runtime_force_suspend|resume() to cover >> also device links. Seems like that becomes really useful together with >> these changes. > > > Is is really needed? I thought that this case is already handled by device > core. It works perfectly fine for Exynos IOMMU and its client devices for > suspend/resume too, which rely on pm_runtime_force_suspend|resume(). Only parent devices are being considered in pm_runtime_force_suspend|resume(). Meaning that the runtime PM usage count will not be updated for a device's link, even if it should. I guess what happens is that the pl330 controller will be brought up to full power during system resume, even if it isn't necessary to do so. If that's the case, it's not the end of the world, we can optimize it later on. Note, this is very theoretical and to be sure, I need to run some tests and think more about it. > >> 2) I think there will be some corner cases during system >> suspend/resume for pl330. Not sure yet though. However, fixing 1) and >> converting the driver to use pm_runtime_force_suspend|resume() should >> probably work anyway. > > > Do you have any particular case in mind? Device links ensures that pl330 > will > suspended after its slave devices and waken before them. Is there anything > more needed here? Likely we can consider them as optimizations. See comment above. > >> Allow me to help out looking into 1) and 2). If not for pl330, I am >> pretty sure it will be useful for other DMA controllers that >> implements device links and runtime PM. > > > I'm open for suggestions. > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
