Re: [PATCH] ioat_alloc_chan_resources should not perform sleeping allocations.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 02, 2017 at 03:54:13PM +0530, Vinod Koul wrote:
> On Fri, Dec 30, 2016 at 08:10:24PM -0800, Krister Johansen wrote:
>  
> > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> > index 90eddd9..9d82f8f 100644
> > --- a/drivers/dma/ioat/init.c
> > +++ b/drivers/dma/ioat/init.c
> > @@ -693,7 +693,7 @@ static int ioat_alloc_chan_resources(struct dma_chan *c)
> >  	/* doing 2 32bit writes to mmio since 1 64b write doesn't work */
> >  	ioat_chan->completion =
> >  		dma_pool_zalloc(ioat_chan->ioat_dma->completion_pool,
> > -				GFP_KERNEL, &ioat_chan->completion_dma);
> > +				GFP_ATOMIC, &ioat_chan->completion_dma);
> 
> can you actually make it GFP_NOWAIT, we prefer that.

Absolutely.  I'll send one that's updated to use that instead.

-K
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux