Re: [PATCH 1/1] dma: ioat: set error code on failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2016 at 03:10:12PM +0800, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
> ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
> value of return variable err is 0 (indicates no error). As a result, the
> return value may be inconsistent with the execution status. This patch
> fixes the bug by assigning -ENOMEM to err on the error path.

Please describe the fix you are doing. For Bugzilla you can use Fixes tag

Also add the correct subsystem tag, so the changelog can look like:

dmaengine: ioat: set error code on failures

In ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 ...

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591
Fixes: Commit you fixes

..

So please update the changelog and resend with Acks collected

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux