On Wednesday 16 November 2016 02:28 AM, Tony Lindgren wrote: > * Sekhar Nori <nsekhar@xxxxxx> [161115 00:35]: >> If pm_runtime_get_sync() fails due to callback error, then >> rpm_callback() sets dev.power.runtime_error to an error value which gets >> cleared by an explicit call to pm_runtime_set_suspended(). >> >> This will tell the framework that the status of device is suspended. >> Else, the failure will be sticky and on subsequent attempts, >> rpm_resume() will keep returning early instead of trying to resume the >> device again. >> >> This is as far as I can gather from code. So, I believe the recovery >> path should be: >> >> if (error < 0) { >> pm_runtime_set_suspended(cdd->ddev.dev); >> pm_runtime_put_noidle(cdd->ddev.dev); >> >> ... > > Well we should test this :) Yes, right! Was this patch created to fix an error in practice or just based on code review? > BTW, what other users of cppi41 do we have in addition to musb? I think > davinci is or will be using it too? The list Bin provided seems accurate. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html