Hi Vinod, On 11/13/2016 10:10 PM, Sinan Kaya wrote: > On 11/13/2016 10:04 PM, Vinod Koul wrote: >> On Wed, Oct 19, 2016 at 02:42:46PM -0400, Sinan Kaya wrote: >>> The 4.8-rc8 kernel is printing duplicate file entry warnings while removing >>> the HIDMA object. This is caused by stale sysfs entries remaining from the >>> previous execution. >>> >>> _sysfs_warn_dup+0x5c/0x78 >>> sysfs_add_file_mode_ns+0x13c/0x1c0 >>> sysfs_create_file_ns+0x2c/0x40 >>> device_create_file+0x54/0xa0 >>> hidma_probe+0x7c8/0x808 >>> >>> Create hidma_sysfs_init and hidma_sysfs_uninit functions and call them from >>> the probe and remove path. To do proper clean up, adding the attrs object >>> to the device data structure to keep it around until remove call is made. >> >> This doesnt apply for me, I think due to other patches applied.. >> > > OK. Let me rebase. > I fetched your topic/qcom branch and applied this patch on top. This is what I see at this moment. 22f20f5 dmaengine: qcom_hidma: cleanup sysfs entries during remove 8cc12b2 dmaengine: qcom_hidma: hide MSI handler when unused 87ffcea dmaengine: qcom_hidma: remove unneeded of_node_put() 1c0e3e8 dmaengine: qcom_hidma: add MSI support for interrupts I posted V3 a minute ago with the contents of 22f20f5. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
