Re: dmatest buffer size alignment honoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 10, 2016 at 05:03:26PM -0700, Dave Jiang wrote:
> Looking at the code it seems that dmatest takes the max aligned buffer
> size from the actual allocated buffer size. This can make the buffer
> being tested much smaller than the actual specified test buffer size.
> When testing, the intent is to test up to N bytes of buffers right?
> Shouldn't we try to allocate a buffer that's large enough to accommodate
> the alignment restriction and then work on the aligned buffer instead?

sounds okay to me, feel free to send a patch..

> 
> i.e.
> src_buf = kmalloc(buf_size+align, GFP_KERNEL);
> src_off += (unsigned long)PTR_ALIGN(src_buf, align) - (unsigned
> long)src_buf;
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux