On Fri, 2016-09-23 at 22:46 +0530, Vinod Koul wrote: > On Fri, Sep 09, 2016 at 10:57:34PM +0300, Andy Shevchenko wrote: > > > > +/* iDMA 32-bit support */ > > Btw whats 32 bit here? AFAIR IP block was 64bit capable.. Nope. BayTrail Audio and Merrifield Audio/GPDMA have iDMA 32-bit. > > +/* Bitfields in CTL_HI */ > > +#define IDMA32C_CTLH_BLOCK_TS_MASK GENMASK(16, 0) > > +#define IDMA32C_CTLH_BLOCK_TS(x) ((x) & > > IDMA32C_CTLH_BLOCK_TS_MASK) > > +#define IDMA32C_CTLH_DONE (1 << 17) > > BIT() here and other places pls I leave this to be consistent with the other definitions in the file. > +#define IDMA32C_CTLH_CH_WEIGHT_MASK GENMASK(28, 18) / > > * weight mask */ > > +#define IDMA32C_CTLH_CH_WEIGHT(x) ((x) << 18) /* > > weight */ > > BIT(x)? Nope, BIT(x) != ((x) << y) -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
