On Fri, Sep 16, 2016 at 09:24:21AM +0200, Geert Uytterhoeven wrote: > Hi Vinod, > > On Thu, Sep 15, 2016 at 7:33 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > > We recently had a conversation about me cribbing that some drivers being > > hard to compile [1]. Arnd suggested [2] to add COMPILE_TEST to these so > > right now. With this I have one ARM config which compiles all drivers. > > > > I used multi_v7 default config and checked the drivers which are not > > compiling and starting fixing them. So most of them were pretty fine, few > > got warning mostly on bad usage of print specifiers with dma_addr_t and > > size_t being major culprits there and few sparse warnings. > > As Lars also noticed for jz4740, this series does quite a bit more than > enabling COMPILE_TEST. Basically it changes: > > - bool "Foo DMA support" > - depends on ARCH_FOO > + bool "Foo DMA support" if COMPILE_TEST && !ARCH_FOO > + default ARCH_FOO > > In addition to allowing to compile test these drivers, it also unconditionally > enables them on the appropriate platforms. I.e. they can no longer > be disabled when building for such a platform. Is that really what you want? > > IMHO it should be as simple as: > > bool "Foo DMA support" > - depends on ARCH_FOO > + depends on ARCH_FOO || COMPILE_TEST > > and allmodconfig will enable the driver for compile testing... Yeah that was my first thought, but we got a better suggestion from Arnd and I do consider DMAengines to be core which should be selected by default. Yes I should have _explictly_ mentioned that in the cover letter, my bad. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
