On Fri, Sep 16, 2016 at 10:41:14AM +0100, Jon Hunter wrote: > > > > Note that "ARCH_ARM" is not a valid Kconfig symbol, unlike "ARM" and "ARM64". Thanks, I will update that.. I will make it ARM and my guess it that it should enable it on both ARM64 and ARM, is that the case? > > > > Is there anything preventing us from building the driver on x86? yes.. > Not that I can think of so probably simplest if we could drop it. As I have mentioned in cover letter, omap and this didn't build. These two have this depends. > > I think that we should also make the "select PM_CLK" to a "depends on > PM_CLK" otherwise we may get ... > > warning: (ARM_GIC_PM && TEGRA_ACONNECT && TEGRA210_ADMA) selects PM_CLK > which has unmet direct dependencies (PM && HAVE_CLK) > warning: (ARM_GIC_PM && TEGRA_ACONNECT && TEGRA210_ADMA) selects PM_CLK > which has unmet direct dependencies (PM && HAVE_CLK) Yes this was first issue, which i did fix by adding depends, but compile failed for other archs for these two. I dont recall the exact errors for these two though. If you guys fix that up, please send patches :) -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
