On Sun, Jul 24, 2016 at 10:38:11AM -0400, Sinan Kaya wrote: > >> + if (rc) > >> + dev_warn(&pdev->dev, > >> + "failed to request MSI irq, falling back to wired IRQ\n"); > >> + return rc; > >> +#else > >> + return -EINVAL; > > > > -EINVAL doesnt sound apt here.. > > What should I use? -ENOENT ? that sounds okay or EIO > >> + return false; > >> + > >> + ret = strcmp(of_compat, "qcom,hidma-1.1"); > >> + } else { > >> + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); > > > > Okay if you ahve a device ID then why do we need new binding? This device as > > you said implies the support for MSI interrupts. > > > Yes, I do have a new device ID for platforms with MSI capability. > > Which new binding are you referring to? If you have "QCOM8062" why do you need DT to tell hidma-1.1 ? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html