Re: [PATCH V2] dmaengine: qcom_hidma: release the descriptor before the callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sinan Kaya wrote:
+	list_for_each_entry_safe(mdesc, next, &list, node) {
  		enum dma_status llstat;
+		dma_async_tx_callback callback;
+		void *param;

  		desc = &mdesc->desc;

@@ -132,18 +135,19 @@ static void hidma_process_completed(struct hidma_chan *mchan)
  		spin_unlock_irqrestore(&mchan->lock, irqflags);

  		llstat = hidma_ll_status(mdma->lldev, mdesc->tre_ch);
-		if (desc->callback && (llstat == DMA_COMPLETE))
-			desc->callback(desc->callback_param);
+		callback = desc->callback;
+		param = desc->callback_param;

It looks to me like 'callback' and 'param' are never actually used.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux