Acked-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
On 7/20/2016 4:12 PM, Dave Jiang wrote:
> This is in preperation of moving to a callback that provides results to the
> callback for the transaction. The conversion will maintain current behavior
> and the driver must convert to new callback mechanism at a later time in
> order to receive results.
>
> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
> drivers/dma/qcom/hidma.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
> index 41b5c6d..a79687e 100644
> --- a/drivers/dma/qcom/hidma.c
> +++ b/drivers/dma/qcom/hidma.c
> @@ -132,8 +132,8 @@ static void hidma_process_completed(struct hidma_chan *mchan)
> spin_unlock_irqrestore(&mchan->lock, irqflags);
>
> llstat = hidma_ll_status(mdma->lldev, mdesc->tre_ch);
> - if (desc->callback && (llstat == DMA_COMPLETE))
> - desc->callback(desc->callback_param);
> + if (llstat == DMA_COMPLETE)
> + dmaengine_desc_get_callback_invoke(desc, NULL);
>
> last_cookie = desc->cookie;
> dma_run_dependencies(desc);
> @@ -413,14 +413,9 @@ static int hidma_terminate_channel(struct dma_chan *chan)
> /* return all user requests */
> list_for_each_entry_safe(mdesc, tmp, &list, node) {
> struct dma_async_tx_descriptor *txd = &mdesc->desc;
> - dma_async_tx_callback callback = mdesc->desc.callback;
> - void *param = mdesc->desc.callback_param;
>
> dma_descriptor_unmap(txd);
> -
> - if (callback)
> - callback(param);
> -
> + dmaengine_desc_get_callback_invoke(txd, NULL);
> dma_run_dependencies(txd);
>
> /* move myself to free_list */
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
