On 07/15/2016 10:21 PM, Dave Jiang wrote: > +enum dmaengine_tx_result { > + DMA_TRANS_NOERROR = 0, > + DMA_TRANS_READ_FAILED, > + DMA_TRANS_WRITE_FAILED, > + DMA_TRANS_ABORTED, > +}; There needs to be a very clear definition on the meaning and semantics of each of these. Otherwise their meaning will become ambiguous over time and clients have to fallback to heuristics to guess what the result actually means. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html