Re: [PATCH v2 23/41] dmaengine: pl330: convert callback to helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

[auto build test ERROR on v4.7-rc7]
[also build test ERROR on next-20160715]
[cannot apply to slave-dma/next xlnx/master]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dave-Jiang/Adding-transaction-result-return-for-dmaengine/20160716-044852
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm64 

All errors (new ones prefixed by >>):

   drivers/dma/pl330.c: In function 'pl330_tasklet':
>> drivers/dma/pl330.c:2042:3: error: unknown type name 'dmaengine_desc_callback'
      dmaengine_desc_callback cb;
      ^
>> drivers/dma/pl330.c:2047:43: error: passing argument 2 of 'dmaengine_desc_get_callback' from incompatible pointer type [-Werror=incompatible-pointer-types]
      dmaengine_desc_get_callback(&desc->txd, &cb);
                                              ^
   In file included from drivers/dma/pl330.c:23:0:
   include/linux/dmaengine.h:1381:1: note: expected 'struct dmaengine_desc_callback *' but argument is of type 'int *'
    dmaengine_desc_get_callback(struct dma_async_tx_descriptor *tx,
    ^
>> drivers/dma/pl330.c:2065:9: error: request for member 'callback' in something not a structure or union
      if (cb.callback) {
            ^
>> drivers/dma/pl330.c:2067:35: error: passing argument 1 of 'dmaengine_desc_callback_invoke' from incompatible pointer type [-Werror=incompatible-pointer-types]
       dmaengine_desc_callback_invoke(&cb, NULL);
                                      ^
   In file included from drivers/dma/pl330.c:23:0:
   include/linux/dmaengine.h:1389:1: note: expected 'struct dmaengine_desc_callback *' but argument is of type 'int *'
    dmaengine_desc_callback_invoke(struct dmaengine_desc_callback *cb,
    ^
   cc1: some warnings being treated as errors

vim +/dmaengine_desc_callback +2042 drivers/dma/pl330.c

  2036			spin_lock(&pch->thread->dmac->lock);
  2037			_start(pch->thread);
  2038			spin_unlock(&pch->thread->dmac->lock);
  2039		}
  2040	
  2041		while (!list_empty(&pch->completed_list)) {
> 2042			dmaengine_desc_callback cb;
  2043	
  2044			desc = list_first_entry(&pch->completed_list,
  2045						struct dma_pl330_desc, node);
  2046	
> 2047			dmaengine_desc_get_callback(&desc->txd, &cb);
  2048	
  2049			if (pch->cyclic) {
  2050				desc->status = PREP;
  2051				list_move_tail(&desc->node, &pch->work_list);
  2052				if (power_down) {
  2053					spin_lock(&pch->thread->dmac->lock);
  2054					_start(pch->thread);
  2055					spin_unlock(&pch->thread->dmac->lock);
  2056					power_down = false;
  2057				}
  2058			} else {
  2059				desc->status = FREE;
  2060				list_move_tail(&desc->node, &pch->dmac->desc_pool);
  2061			}
  2062	
  2063			dma_descriptor_unmap(&desc->txd);
  2064	
> 2065			if (cb.callback) {
  2066				spin_unlock_irqrestore(&pch->lock, flags);
> 2067				dmaengine_desc_callback_invoke(&cb, NULL);
  2068				spin_lock_irqsave(&pch->lock, flags);
  2069			}
  2070		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux