On Fri, Jul 15, 2016 at 03:07:21PM +0530, Vinod Koul wrote:
On Fri, Jul 15, 2016 at 05:21:27PM +0800, Fengguang Wu wrote:On Fri, Jul 15, 2016 at 02:45:20PM +0530, Vinod Koul wrote: >On Fri, Jul 15, 2016 at 10:10:29AM +0300, Laurent Pinchart wrote: >>Hi Dave, >> >>Thank you for the patch. >> >>On Thursday 14 Jul 2016 14:59:11 Dave Jiang wrote: >>> Convert driver to use the new helper function for callback >>> >>> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx> >>> --- >>> drivers/dma/sh/rcar-dmac.c | 14 ++++++-------- >>> 1 file changed, 6 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c >>> index dfb1792..ca39265 100644 >>> --- a/drivers/dma/sh/rcar-dmac.c >>> +++ b/drivers/dma/sh/rcar-dmac.c >>> @@ -1356,21 +1356,18 @@ static irqreturn_t rcar_dmac_isr_channel_thread(int >>> irq, void *dev) { >>> struct rcar_dmac_chan *chan = dev; >>> struct rcar_dmac_desc *desc; >>> + struct dma_desc_callback cb; >>> >>> spin_lock_irq(&chan->lock); >>> >>> /* For cyclic transfers notify the user after every chunk. */ >>> if (chan->desc.running && chan->desc.running->cyclic) { >>> - dma_async_tx_callback callback; >>> - void *callback_param; >>> - >>> desc = chan->desc.running; >>> - callback = desc->async_tx.callback; >>> - callback_param = desc->async_tx.callback_param; >>> + dmaengine_desc_get_callback(&desc->async_tx, &cb); >>> >>> - if (callback) { >>> + if (cb->callback) { >> >>/home/laurent/src/iob/renesas/linux/drivers/dma/sh/rcar-dmac.c: In function >>‘rcar_dmac_isr_channel_thread’: >>/home/laurent/src/iob/renesas/linux/drivers/dma/sh/rcar-dmac.c:1368:9: error: >>invalid type argument of ‘->’ (have ‘struct dma_desc_callback’) >>/home/laurent/src/iob/renesas/linux/scripts/Makefile.build:295: recipe for >>target 'drivers/dma/sh/rcar-dmac.o' failed >>make[4]: *** [drivers/dma/sh/rcar-dmac.o] Error 1 >>make[4]: *** Waiting for unfinished jobs.... >> >>Given that two of the two drivers I tried to compile failed, I think you >>should really get an ARM cross-compiler to test the series. They're quite >>widely available nowadays :-) > >:-) > >And am surprised why Fengguang's bot didn't pick this up. Fengguang..? Sorry 0day bot doesn't see that build error. In which tree/branch does it happen?My dmaengine tree, I dont think the bot ran on this patch series. Can you check has it got disabled somehow for dmaengine list..
Here are the latest build notifications: 673 F Jul 12 To Vinod Koul ( 127:0) [slave-dma:topic/mv_xor] f1532019dd5b2a9c5b659896968626e6e8fb232e BUILD SUCCESS 674 F Jul 12 To Vinod Koul ( 117:0) [slave-dma:next] 600602de6b6b691e0aed20913984e4d0bf2d370d BUILD SUCCESS 675 F Jul 12 To Vinod Koul ( 127:0) [slave-dma:topic/xilinx] 7cdd3587b8628215f377d5d73a39540d94f33dc1 BUILD SUCCESS 677 F Jul 12 To Vinod Koul ( 142:0) [slave-dma:for-linus] 1d069bfa3c78c6d0285e5e370710cf7062c71308 BUILD SUCCESS 678 F Jul 12 To Vinod Koul ( 127:0) [slave-dma:next] 57494e833e222e0fddf4dcb53dfe70924b7bc420 BUILD SUCCESS Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
