On Thu, 2016-05-05 at 18:54 +0100, Bryan O'Donoghue wrote: > On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > > > > + bool polarity; > So this variable is not very intuitively named. There is a help above. This is a property of the Synopsys DesignWare DMA engine. Anyone familiar with datasheet easily understands this. > > You end up setting somepointer->polarity = true; in a later patch. > > Since you're respining a V4 I'd suggest a name that describes a little > bit better than polarity. Setting polarity = true is a little bit > liked > being asked "you you like ice-cream or apple pie" and then saying "yes > please". It's about handshake interface polarity, so, what about hs_polarity? -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
