On Wed, Apr 27, 2016 at 01:59:23PM +0100, Peter Griffin wrote: > > bunch of this seems similar to cyclic case, can you create common setup > > routine for these, anyway cyclic is a special cases of slave_sg > > In v4 I've made a st_fdma_prep_common() which abstracts out all the common > checks at the beginning of the *_prep*() functions. > > In v3 fill_fw_node() is already (from one of your previous reviews) > abstracting out all the common parts from these loops. So everything > that is now left is actually differences between the two setups. > > Is that Ok? Sounds better > > and you irq is still enabled and tasklets can be scheduled!! > > > Eeek! Very good point. Also looking at some other drivers we > should be doing a of_dma_controller_free() and > dma_async_device_unregister(). > > So something like this: - > > st_fdma_disable(); /*disables irqs*/ > of_dma_controller_free(pdev->dev.of_node); > dma_async_device_unregister(&priv->slave); > st_fdma_clk_disable(fdev); you can call devm_free_irq() explictyly, that will syncronize irq and free it up. Also you should kill the tasklet afterwards. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
