Re: linux-4.6-rc5/drivers/dma/imx-sdma.c:1003: possible typo ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 25, 2016 at 06:21:47PM +0000, David Binderman wrote:
> Hello there,
> 
> [linux-4.6-rc5/drivers/dma/imx-sdma.c:1003]: (style) Same expression on both sides of '|='.
> 
> Source code is
> 
>         /* Watermark Level */
>         sdmac->watermark_level |= sdmac->watermark_level;
> 
> I am not sure what this code is supposed to be doing, but this looks like
> a typo to me.

Looks like the case, we can remove it and hope someone notices and fixes :)


> 
> Also:
> 
> [drivers/dma/imx-sdma.c:769]: (style) Variable 'emi_2_emi' is assigned a value that is never used.

This should be removed

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux