On Tue, Mar 29, 2016 at 3:03 PM, Johannes Stezenbach <js@xxxxxxxxx> wrote:
>> + /*
>> + * For engines with fixed signal assignment for slave transfers,
>> + * this signal is assigned during probe.
>> + */
>> + if (plchan->host->vd->fixed_signals) {
>> + BUG_ON(plchan->signal < 0);
>> + return 0;
>> + }
>> +
>> if (plchan->mux_use++ == 0 && pd->get_xfer_signal) {
>
> If the platform doesn't have a mux (and thus has fixed signals),
> so far pd->get_xfer_signal returned the signal.
> Now with dt, pd->get/put_xfer_signal aren't set and thus
> pl08x_request/release_mux() won't do anything. So I think
> the check above is not needed.
It's there because I think it is not logical to keep counting
up/down mux_use when you don't have a mux.
But I have dropped this for now, the important is that we
can get our systems running.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
