On Mon, Mar 21, 2016 at 09:35:33AM +0100, Jean-Francois Moine wrote:
> On Mon, 21 Mar 2016 08:29:18 +0100
> Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
>
> > > @@ -470,6 +473,10 @@ static int set_config(struct sun6i_dma_dev *sdev,
> > > {
> > > s8 src_width, dst_width, src_burst, dst_burst;
> > >
> > > + if (!sdev->cfg->burst_4 &&
> > > + (sconfig->src_maxburst == 4 || sconfig->dst_maxburst == 4))
> > > + return -EINVAL;
> > > +
> >
> > I still believe this should be dealt with at the framework level.
>
> What do you mean? In the DMA clients?
No, in the dmaengine framework.
A driver should register the burst size they support, and
dmaengine_slave_config would reject any invalid burst size based on
that.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
