Hi, On mar., mars 22 2016, Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote: > Hi Dan, > > On mar., mars 22 2016, Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > >> On Tue, Mar 22, 2016 at 8:36 AM, Gregory CLEMENT >> <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote: >>> >>> Hi, >>> >>> while using the dmatest module to test the mv_xor.c driver, I got >>> failures. I finally found that when the "noverify" parameter is not set, >>> then the buffer length used is totally random (modulo the maximum size >>> of the buffer). But in the mv_xor_prep_dma_xor there is a test about the >>> minimal size the dmaengine can use. So when the length was under this >>> minimum size then I got some test failures like the following: "dmatest: >>> dma1chan0-copy0: result #11: 'prep error' with src_off=0x29c9 >>> dst_off=0x1c51 len=0x33 (0)". >>> >>> Unless the drivers are supposed to accept all buffer size I think it is >>> not an error, and I would like to be able to use this dmatest for >>> automatic test and not to have to check if the error is a real one or >>> not. >>> >>> I think that the following patch could improve the dmatest module. >>> >>> What do you think about it? >>> >>> Did I miss something or is a good ieda to send a proper patch? >> >> Looks like a useful patch to me. > > Thanks for your prompt answer, so I am going to send patch on the ML to > have a real review. In the meantime, my colleague Thomas Petazzoni found that it would make more sens to make the framework aware of this limitation instead of having to know the minimum size for each dma test. We could do it in the same way that it was done for the alignment constraint. What do you think of it? Gregory > > Thanks, > > Gregory > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
