On Fri, Mar 18, 2016 at 03:21:11PM +0100, Jean-Francois Moine wrote: > As the max burst and bus width values are now checked, there is > no reason to check them again when setting the hardware registers. > > Signed-off-by: Jean-Francois Moine <moinejf@xxxxxxx> > --- > drivers/dma/sun6i-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 3f73123..643ba4c 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -65,8 +65,8 @@ > #define DMA_CHAN_CFG_SRC_DRQ(x) ((x) & 0x1f) > #define DMA_CHAN_CFG_SRC_IO_MODE BIT(5) > #define DMA_CHAN_CFG_SRC_LINEAR_MODE (0 << 5) > -#define DMA_CHAN_CFG_SRC_BURST(x) (((x) & 0x3) << 7) > -#define DMA_CHAN_CFG_SRC_WIDTH(x) (((x) & 0x3) << 9) > +#define DMA_CHAN_CFG_SRC_BURST(x) ((x) << 7) > +#define DMA_CHAN_CFG_SRC_WIDTH(x) ((x) << 9) Well, you can easily end up with values higher than that. I still believe that making sure you only always write what is expected is a good thing. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
