On Mon, 2016-02-08 at 08:27 +0530, Vinod Koul wrote: > On Fri, Jan 22, 2016 at 12:22:34PM +0200, Andy Shevchenko wrote: > > On Thu, 2016-01-21 at 11:26 +0200, Westerberg, Mika wrote: > > > On Wed, Jan 20, 2016 at 06:21:36PM +0200, Andy Shevchenko wrote: > > > > Even if we are not going to get a channel the message is > > > > issued. > > > > Check the > > > > result of acpi_dma_request_slave_chan_by_index() before issuing > > > > the > > > > message. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.c > > > > om> > > > > > > The debug message is there because it prints out the index of the > > > FixedDMA descriptor we are trying to get channel for -- even if > > > we > > > cannot get the channel. > > > > Then it should sound a bit differently, shoudln't it? > > > > Something like > > > > dev_dbg(dev, "Looking for DMA channel \"%s\" at index %d...\n", > > name, > > index); > > Yes that sound much better than orignal one :) Yes, since Mika wants to see something before matching, we probably have to change just message. I will send v2 soon with Mika's Ack as agreed with him. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
