On Thu, Dec 10, 2015 at 03:18:33PM +0200, Stanimir Varbanov wrote: <snip> > >>> This is just using the #define. That is ok, but if you use this instead of the > >>> BAM_P_FIFO_SIZES then you need to fix your comment. Or actually use the > >>> register value.... otherwise looks fine. > >> > >> I did not follow your comment, but the intension of the patch is to set > >> the proper FIFO size in BAM_P_FIFO_SIZES register, i.e. 32K - 8. > > > > Sorry, I mixed up the usage and was thinking there was something you read out > > that told you the size. That's not how it works, unfortunately. The > > MAX_DATA_SIZE is fine, but the name is a little misleading. Perhaps just > > BAM_FIFO_SIZE? > > OK I can rename BAM_MAX_DATA_SIZE to BAM_FIFO_SIZE, and use it when > setting BAM_P_FIFO_SIZES register. Is that fine to you? Yes that's fine with me. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
