Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi John,

On 01/22/2016 02:27 AM, John Ogness wrote:
> Note that an ugly device-tree lookup hack is implemented in order
> to detect if the sDMA engine is being used. This is necessary
> because the sDMA driver does not implement pause/resume correctly
> and therefore requires slightly different logic for the UART
> driver.

No, this is not acceptable.

Please work with Vinod to refine the dma_get_slave_caps() interface
so that dmaengine drivers that don't provide the _documented_ pause/resume
support can be identified generically.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux