On Thu, Jan 07, 2016 at 05:33:02PM +0000, kernel@xxxxxxxxxxxxxxxx wrote: > +#define BCM2835_DMA_PRIORITY(x) ((x & 15) << 16) /* AXI priority */ > +#define BCM2835_DMA_PANIC_PRIORITY(x) ((x & 15) << 20) /* panic priority */ > +#define BCM2835_DMA_WAIT_FOR_WRITES BIT(28) /* current value of > + * TI.BCM2835_DMA_WAIT_RESP > + */ I would put the comment before this, yes is not consistent but is more readable.. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html