Hi Dan,
Ok I understand the issue.
Thanks for this notification.
Hi Vinod,
So, as this patch is already applied in slave-dma/next branch what is
the way of working to correct it ?
I mean I have to push a V5 or a patch that fixes this specific issue ?
BR,
Cedric
2015-11-19 13:46 GMT+01:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> Hello M'boumba Cedric Madianga,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch d8b468394fb7: "dmaengine: Add STM32 DMA driver" from Oct
> 16, 2015, leads to the following Smatch complaint:
>
> drivers/dma/stm32-dma.c:562 stm32_dma_issue_pending()
> error: we previously assumed 'chan->desc' could be null (see line 560)
>
> drivers/dma/stm32-dma.c
> 559 if (!chan->busy) {
> 560 if (vchan_issue_pending(&chan->vchan) && !chan->desc) {
> ^^^^^^^^^^
> Check.
>
> 561 ret = stm32_dma_start_transfer(chan);
> 562 if ((chan->desc->cyclic) && (!ret))
> ^^^^^^^^^^^^^^^^^^
> Unchecked dereference.
>
> There are some paths where stm32_dma_start_transfer() does allocate
> chan->desc but keep in mind that just because it returns zero doesn't
> mean that it was allocated. For example if vchan_next_desc() returns
> NULL then stm32_dma_start_transfer() returns success without allocating
> ->desc.
>
> 563 stm32_dma_configure_next_sg(chan);
> 564 }
>
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
