On Thu, Oct 29, 2015 at 11:03 PM, Han Xu <han.xu@xxxxxxxxxxxxx> wrote: > On Thu, Oct 29, 2015 at 11:08:10PM +0200, Andy Shevchenko wrote: >> On Wed, Oct 28, 2015 at 12:05 AM, Han Xu <b45815@xxxxxxxxxxxxx> wrote: >> > From: Adrian Alonso <aalonso@xxxxxxxxxxxxx> >> > >> > supports APBH DMA on i.MX7D by add extra clock clk_io >> >> [] >> >> > MODULE_DEVICE_TABLE(of, mxs_dma_dt_ids); >> > @@ -440,6 +448,13 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan) >> > if (ret) >> > goto err_clk; >> > >> > + /* enable the extra clk_io clock for i.MX7D */ >> > + if (mxs_dma->dev_id == IMX7D_DMA) { >> > + ret = clk_prepare_enable(mxs_dma->clk_io); >> > + if (ret) >> > + goto err_clk_unprepare; >> >> Perhaps err_clk. >> > it is err_clk_unprepare Ah, you are right. >> > + } >> > + >> > mxs_dma_reset_chan(chan); >> > >> > dma_async_tx_descriptor_init(&mxs_chan->desc, chan); >> > @@ -450,6 +465,8 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan) >> > >> > return 0; >> > >> > +err_clk_unprepare: >> > + clk_disable_unprepare(mxs_dma->clk); >> > err_clk: >> > free_irq(mxs_chan->chan_irq, mxs_dma); -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html