On Mon, Oct 12, 2015 at 12:24:48PM +0300, Andy Shevchenko wrote: > By the way, I think that ->shutdown() hook doesn't add a much value at > all. On one hand the users have to care about being quiescent during > shutdown, on the other there is nothing to prevent an abruption of > execution. The only thing worth to care is kexec flow. > > Vinod, we have really few DMA drivers that implement ->shutdown() hook. > Do we really need it there and thus does is make sense to add to all > DMA drivers? I think that would be sane thing to do. if the user is not able to terminate the dma, doing so in shutdown callback and ensuring you are handing off the device in quiescent state would be a good idea -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html