Hi, On Thu, 08 Oct 2015, Koul, Vinod wrote: > On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote: > > > +#define FDMA_ID_OFST 0x00000 > > +#define FDMA_VER_OFST 0x00004 > > > + > > +#define FDMA_EN_OFST 0x00008 > > Why cant these be BIT() to maintain consistency? > These are actually register offsets. I'm only using the BIT macro for bitfields within the registers e.g. FDMA_EN_RUN regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html