> > Below I asked you why do you have such issue in the first place? We reproduce this issue on Customer board, we do the poweroff stress test case on Android device: While(1) { Open any apps, like run monkey test reboot } It hard to reproduce, but we have encounter this issue 2 times those days. So I think it will go into fault state of state machine on this IP in extreme case. > > > > > > > > > By the way, I think that ->shutdown() hook doesn't add a much value > > > at all. > > > > I don’t agree with it, it maybe ok on Intel SOCs, but this driver is > > for synopsys dmac ip, So it should need the shutdown for other SOC > > vendors like ARM base vendors. We should Sync the dma before shutdown. > > I'm talking about DMA IP and as you noticed I asked Vinod as well to share > his opinion about ->shutdown() hook. > > > > > > On one hand the users have to care about being quiescent during > > > shutdown, on the other there is nothing to prevent an abruption of > > > execution. > > > > In normal work flow, it maybe ok. But if the state machine in wrong > > state for some corner case for this synopsys dmac controller, so > > current code will go into dead loop. > > I'm not objecting this patch, but it fixes the symptoms (though that is okay > since the unlimited busy loops is a bad idea and I already propose d a fix half > a year ago), not the original issue. Yes. ��.n��������+%������w��{.n��������)�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥