Re: [PATCH 2/3] dma: pl08x: allocate OF slave channel data at probe time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6 October 2015 at 12:27, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> The current OF translation of channels can never work with
> any DMA client using the DMA channels directly: the only way
> to get the channels initialized properly is in the
> dma_async_device_register() call, where chan->dev etc is
> allocated and initialized.
>
> Allocate and initialize all 32 possible DMA channels and
> only augment a target channel with the periph_buses at
> of_xlate(). Remove some const settings to make things work.
>
> Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> Cc: Joachim Eastwood <manabian@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> Joachim: I think I need your teste-by on this to make sure
> the LPC machine survives this patch set.
> ---
>  drivers/dma/amba-pl08x.c   | 80 +++++++++++++++++++++++++++++-----------------
>  include/linux/amba/pl08x.h |  2 +-
>  2 files changed, 52 insertions(+), 30 deletions(-)

This breaks dma on lpc18xx.

Seems like the slaves are unable to find the dma channel with this change.
Full boot log: http://slexy.org/raw/s20nJ4Gpyx

regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux