On Fri, Sep 25, 2015 at 03:56:39PM +0100, Jon Hunter wrote: > Add device-tree binding documentation for the Tegra210 Audio DMA > controller. > > Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > --- > .../devicetree/bindings/dma/tegra210-adma.txt | 47 ++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/tegra210-adma.txt > > diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt b/Documentation/devicetree/bindings/dma/tegra210-adma.txt > new file mode 100644 > index 000000000000..af04b3c5a557 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/tegra210-adma.txt > @@ -0,0 +1,47 @@ > +* NVIDIA Tegra Audio DMA controller > + > +Required properties: > +- compatible: Should be "nvidia,<chip>-adma" Where <chip> can be? > +- reg: Should contain DMA registers location and length. This should include > + all of the per-channel registers. This is one contiguous bank? > +- interrupt-parent: Phandle to the interrupt parent controller. > +- interrupts: Should contain all of the per-channel DMA interrupts. In which particular order? > +- clocks: Must contain two entries, one for the power-domain clock and one > + for the module clock. See ../clocks/clock-bindings.txt for details. The example dts and driver rely on clock-names. Please define the set of clock-names, and define clocks in terms of clock-names. > +- dma-channels: Number of DMA channels supported by the controller. > +- #dma-cells : Must be <0>. As others have pointed out, this doesn't seem right. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html