Re: [PATCH v1 5/6] avr32: use dw_dmac autoconfiguration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Around Thu 17 Sep 2015 12:15:21 +0300 or thereabout, Andy Shevchenko wrote:
> Instead of hardconding a platform data for dw_dmac let's use it's own
>

... hardcoding ...

> autoconfiguration feature. Thus, remove hardcoded values.
>

I did not know the DMA controller within AP700x had a register containing the
configuration, but this sounds great.

> Tested on ATNGW100.
> 
> Cc: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>

> ---
>  arch/avr32/mach-at32ap/at32ap700x.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
> index 1d8b147..b4cb3bd 100644
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -603,18 +603,11 @@ static void __init genclk_init_parent(struct clk *clk)
>  	clk->parent = parent;
>  }
>  
> -static struct dw_dma_platform_data dw_dmac0_data = {
> -	.nr_channels	= 3,
> -	.block_size	= 4095U,
> -	.nr_masters	= 2,
> -	.data_width	= { 2, 2 },
> -};
> -
>  static struct resource dw_dmac0_resource[] = {
>  	PBMEM(0xff200000),
>  	IRQ(2),
>  };
> -DEFINE_DEV_DATA(dw_dmac, 0);
> +DEFINE_DEV(dw_dmac, 0);
>  DEV_CLK(hclk, dw_dmac0, hsb, 10);
>  
>  /* --------------------------------------------------------------------
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux