Hi Hamza,
On Tue, Sep 15, 2015 at 5:44 PM, Farooq, Muhammad (M.HAMZA.)
<mfarooq@xxxxxxxxxxx> wrote:
>> I would add a cpu_relax() to the loop.
> This routine is being called from soft IRQ context (rx_timer_fn in case of sh-sci). Does it still make sense to add cpu_relax?
Yes, it will add an explicit barrier.
Possibly the implicit barrier in readw() in rcar_dmac_chan_read() is already
good enough, but it's better to make this explicit.
>> BTW, please run scripts/checkpatch.pl on your patches before submission.
> I did run that and got no warning/error. Am I missing something?
Strange. I get several warnings, e.g. for a missing space after the "if" in
"if(!(chcr & RCAR_DMACHCR_DE))".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
