Hi Vinod,
On Thu, Aug 20, 2015 at 11:18 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:
> On Thu, Jul 30, 2015 at 05:41:07PM +0530, Rameshwar Prasad Sahu wrote:
>> + nents = sg_nents(req->src);
>> + sg_count = dma_map_sg(dev, req->src, nents, DMA_TO_DEVICE);
>> + if (!sg_count) {
>> + dev_err(dev, "Failed to map src sg");
>> + return -ENOMEM;
> mapping error shouldn't be no mem error
Okay, I guess then -EIO will be fine here??
>
>> + }
>> +
>> + if (sg_count > XGENE_DMA_MAX_FLYBY_SRC_CNT) {
>> + dev_err(dev, "Unsupported src sg len\n");
> would be worth printing length
Okay,
>
>> + goto err;
>> + }
>> +
>> + flags = DMA_CTRL_ACK;
> why ACK?
My understanding about DMA_CTRL_ACK is dma engine driver can
re-use/free this descriptor once operation completed in cleanup path.
Am I correct ??
But yes, I need to look on this because recently you have added one
more descriptor flag.
>
>> +
>> + tx = dchan->device->device_prep_dma_crc32c(dchan, req->src,
>> + req->nbytes,
>> + reqctx->seed,
>> + req->result,
>> + flags);
> We should add helper for this
Okay
>
> --
> ~Vinod
>
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
