re: dma: Add Freescale eDMA engine driver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jingchang Lu,

This is a semi-automatic email about new static checker warnings.

The patch d6be34fbd39b: "dma: Add Freescale eDMA engine driver 
support" from Feb 18, 2014, leads to the following Smatch complaint:

drivers/dma/fsl-edma.c:420 fsl_edma_tx_status()
	 error: we previously assumed 'fsl_chan->edesc' could be null (see line 417)

drivers/dma/fsl-edma.c
   416		vdesc = vchan_find_desc(&fsl_chan->vchan, cookie);
   417		if (fsl_chan->edesc && cookie == fsl_chan->edesc->vdesc.tx.cookie)
                    ^^^^^^^^^^^^^^^
Checked for NULL.

   418			txstate->residue = fsl_edma_desc_residue(fsl_chan, vdesc, true);
   419		else if (vdesc)
   420			txstate->residue = fsl_edma_desc_residue(fsl_chan, vdesc, false);
                                                                 ^^^^^^^^
Unchecked dereference inside the function.

   421		else
   422			txstate->residue = 0;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux