Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik@xxxxxxx wrote:
> ----- Mail original -----
> De: "Vinod Koul" <vinod.koul@xxxxxxxxx>
> On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> > This fixes the following error:
[]
> And with a a bit closer look check this commit, especially the date :
> commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
> Author: Joe Perches <joe@xxxxxxxxxxx>
> Date:   Sat May 23 12:00:38 2015 +1000
> 
>     fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

Hello Robert.

The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.

It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.

It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux